Skip to content

ammonite: 0.9.9 -> 1.0.0 #27133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2017
Merged

ammonite: 0.9.9 -> 1.0.0 #27133

merged 2 commits into from
Jul 7, 2017
+22 −2

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update, add test

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@NeQuissimus
ammonite: 0.9.9 -> 1.0.0
aebe858
@NeQuissimus
ammonite: add test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fbbf926
@NeQuissimus NeQuissimus added 0.kind: question Requests for a specific question to be answered 8.has: package (update) This PR updates a package to a newer version 9.needs: community feedback labels Jul 5, 2017
@NeQuissimus
Copy link
Member Author

I added a simple test. The tests seem to live in nixos/tests. Do we not want package tests?

@NeQuissimus NeQuissimus merged commit 8ab9f99 into NixOS:master Jul 7, 2017
@NeQuissimus NeQuissimus deleted the ammonite_1_0_0 branch July 7, 2017 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: question Requests for a specific question to be answered 8.has: package (update) This PR updates a package to a newer version 9.needs: community feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@NeQuissimus