Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 3f39ea26e53f^
Choose a base ref
...
head repository: cdk/cdk
compare: 2385c184f7e4
Choose a head ref
  • 10 commits
  • 22 files changed
  • 1 contributor

Commits on Jun 17, 2017

  1. Default implementation of new IAtom/IBond access methods. 

    For normal atoms/bonds we return null when requested or
unsupported operation - see IAtom/IBond JavaDoc.
    @johnmay
    johnmay committed Jun 17, 2017
    Copy the full SHA
    3f39ea2 View commit details
    Browse the repository at this point in the history

  2. Atom/Bond Ref Implementations

    @johnmay
    johnmay committed Jun 17, 2017
    Copy the full SHA
    a0a4dc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2017

  1. Add atoms before adding bonds.

    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    48a0b14 View commit details
    Browse the repository at this point in the history

  2. Some missed reference compares.

    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    cf54bce View commit details
    Browse the repository at this point in the history

  3. Correct way to test AtomContainer was created with the SilentBuilder.

    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    8873d15 View commit details
    Browse the repository at this point in the history

  4. Add bond after the atoms have been added.

    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    3ab5037 View commit details
    Browse the repository at this point in the history

  5. Remove redundant cast.

    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    4d2ffba View commit details
    Browse the repository at this point in the history

  6. Use non-identity hash map.

    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    e010f11 View commit details
    Browse the repository at this point in the history

  7. Safe getBegin/getEnd methods.

    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    98db74d View commit details
    Browse the repository at this point in the history

  8. When comparing bond/atom to bondref/atomref we swap the operands to e… 

    …nsure we don't break transitivity, a == b then b == a.
    @johnmay
    johnmay committed Jun 20, 2017
    Copy the full SHA
    2385c18 View commit details
    Browse the repository at this point in the history