Merge pull request #690 from metacpan/mickey/rev_deps_old_ep_cleanup

Cleanup unused controller and related code
metacpan · Jun 20, 2017 · abbab23 · abbab23
2 parents f25c9e5 + 6b7f2f2
commit abbab23
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 280 deletions.
diff --git a/lib/MetaCPAN/Document/File/Set.pm b/lib/MetaCPAN/Document/File/Set.pm
@@ -112,25 +112,6 @@ sub find_pod {
     }
 }
 
-# return files that contain modules that match the given dist
-# NOTE: these still need to be filtered by authorized/indexed
-# TODO: test that we are getting the correct version (latest)
-sub find_provided_by {
-    my ( $self, $release ) = @_;
-    return $self->filter(
-        {
-            bool => {
-                must => [
-                    { term => { 'release'           => $release->{name} } },
-                    { term => { 'author'            => $release->{author} } },
-                    { term => { 'module.authorized' => 1 } },
-                    { term => { 'module.indexed'    => 1 } },
-                ]
-            }
-        }
-    )->size(999)->all;
-}
-
 sub documented_modules {
     my ( $self, $release ) = @_;
     return $self->filter(
@@ -171,18 +152,6 @@ sub documented_modules {
     )->size(999);
 }
 
-# filter find_provided_by results for indexed/authorized modules
-# and return a list of package names
-sub find_module_names_provided_by {
-    my ( $self, $release ) = @_;
-    my $mods = $self->inflate(0)->find_provided_by($release);
-    return (
-        map { $_->{name} }
-        grep { $_->{indexed} && $_->{authorized} }
-        map { @{ $_->{_source}->{module} } } @{ $mods->{hits}->{hits} }
-    );
-}
-
 =head2 find_download_url
 
 

diff --git a/lib/MetaCPAN/Document/Release.pm b/lib/MetaCPAN/Document/Release.pm
@@ -316,17 +316,6 @@ sub aggregate_status_by_author {
     return \%ret;
 }
 
-sub find_depending_on {
-    my ( $self, $modules ) = @_;
-    return $self->filter(
-        {
-            or => [
-                map { { term => { 'dependency.module' => $_ } } } @$modules
-            ]
-        }
-    );
-}
-
 sub find {
     my ( $self, $name ) = @_;
     return $self->filter(

diff --git a/lib/MetaCPAN/Server/Controller/Search/ReverseDependencies.pm b/lib/MetaCPAN/Server/Controller/Search/ReverseDependencies.pm
diff --git a/t/model/release/reverse_dependencies.t b/t/model/release/reverse_dependencies.t
@@ -0,0 +1,45 @@
+use strict;
+use warnings;
+
+use MetaCPAN::Server ();
+use Test::More;
+
+my $c = 'MetaCPAN::Server';
+
+subtest 'reverse_dependencies' => sub {
+    my $data = [
+        sort { $a->[1] cmp $b->[1] }
+            map +[ @{$_}{qw(author name)} ],
+        @{
+            $c->model('CPAN::Release')
+                ->raw->reverse_dependencies('Multiple-Modules')->{data}
+        }
+    ];
+
+    is_deeply(
+        $data,
+        [
+            [ LOCAL => 'Multiple-Modules-RDeps-2.03' ],
+            [ LOCAL => 'Multiple-Modules-RDeps-A-2.03' ],
+        ],
+        'Got correct reverse dependencies for distribution.'
+    );
+};
+
+subtest 'reverse_dependencies' => sub {
+    my $data = [
+        map +[ @{$_}{qw(author name)} ],
+        @{
+            $c->model('CPAN::Release')->raw->requires('Multiple::Modules')
+                ->{data}
+        }
+    ];
+
+    is_deeply(
+        $data,
+        [ [ LOCAL => 'Multiple-Modules-RDeps-2.03' ], ],
+        'Got correct reverse dependencies for module.'
+    );
+};
+
+done_testing;
diff --git a/t/server/controller/search/reverse_dependencies.t b/t/server/controller/search/reverse_dependencies.t
diff --git a/t/server/model/file.t b/t/server/model/file.t