-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named Data Networking (NDN) Tools #26923
Conversation
@MostAwesomeDude, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg and @sjmackenzie to be potential reviewers. |
Hm. These actually do have releases; I'm going to fix that and rebase. |
# To do battle with the tests, add --with-tests to the configure above. ~ C. | ||
doCheck = false; | ||
checkPhase = '' | ||
LDD_LIBRARY_PATH=build/ build/unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you mean LD_LIBRARY_PATH?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Fixed. The tests still don't pass, of course.
preConfigure = '' | ||
patchShebangs waf | ||
./waf configure \ | ||
--boost-includes=${boost.dev}/include \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs quoting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this one, or in all of the configures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff. Thanks for your contribution.
version = "2b7b83"; | ||
in | ||
stdenv.mkDerivation { | ||
name = "ndn-tools-0.1-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name is probably wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a mistake! Thanks.
I've addressed all feedback and am ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix merge conflicts
Are there any updates on this pull request, please? |
Hi, I rebased the branch and also bumped the versions of all new packages. It seems that, at some point, a derivation based on my ndn-cxx work got merged, so now the branch's history is a bit messy. I can redo all of the commits, if desired. I haven't been poking at this stuff for a while, though. |
@matthewbauer I believe the merge conflicts were resolved. Can you merge please? |
}; | ||
buildInputs = [ wafHook | ||
libpcap doxygen boost pkgconfig python pythonPackages.sphinx | ||
openssl ndn-cxx ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ wafHook doxygen pkgconfig python pythonPackages.sphinx ];
sha256 = "1sjhyhc9ww38vyf3qmjzh5c4c0jc43ypzjmpqwsbq8y5zzln0gfx"; | ||
}; | ||
|
||
buildInputs = [ wafHook libpcap openssl boost pkgconfig python pythonPackages.sphinx git ndn-cxx ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ wafHook pkgconfig python pythonPackages.sphinx git ];
btw. why is git
required here?
sha256 = "0pdinvq3cf458bmm2mxdlidrmmr38in1563ra8q0ch3wp45va2di"; | ||
}; | ||
buildInputs = [ wafHook libpcap openssl doxygen boost sqlite pkgconfig | ||
python pythonPackages.sphinx ndn-cxx ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ wafHook doxygen pkgconfig python pythonPackages.sphinx ];
}; | ||
|
||
nativeBuildInputs = [ pkgconfig wafHook ]; | ||
buildInputs = [ openssl doxygen boost sqlite python pythonPackages.sphinx]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also doxygen, python and sphinx should be in nativeBuildInputs
And use fetchFromGitHub.
ndn-tools: use fetchFromGitHub
repo-ng: Fix up name and pick a working revision. And use fetchFromGitHub too.
Also bump nfd, ndn-tools, repo-ng, as they all seem very tied-together in terms of versioning.
ndn-cxx has been updated to 0.7.1 in master. You could rebase |
I marked this as stale due to inactivity. → More info |
Motivation for this change
I want to play with NDN.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)I had to use versions from git because this stuff is so bleeding-edge.