Fixed cleanup of 'terminado' and 'tornado' #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a minor change, not worthy of a changelog entry. Most users don’t care about building snaps. |
|
OK, thanks. So I'll leave the changelog unmodified for future
modifications of the snapcraft.yaml file.
|
After creating the snap, these are directories containing files. So you cannot delete them via 'rm'
uli-heller
force-pushed
the
fix-snap-rmrf
branch
from
33b70f5
to
2529877
Compare
|
I've updated the PR, no more changes to CHANGES.txt |
|
Using |
uli-heller
added a commit
to uli-heller/nikola
that referenced
this pull request
Jul 19, 2017
* Fixed cleanup of 'terminado' and 'tornado' After creating the snap, these are directories containing files. So you cannot delete them via 'rm' * 'snapcraft clean nikola -s pull;snapcraft' produced an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating the snap, these are directories containing files. So you
cannot delete them via 'rm'
Pull Request Checklist
Description
Without this change, you'll get an error message towards the end of the
creation of the snap. Unfortunately, I don't have a copy of it available at the moment.
I can recreate it when required.