[ji] (auto) convert java numbers #4718
Conversation
preparing to be able to handle Java numbers while keeping compat
|
@headius am happy to move off and merge this to ruby-2.4 (expect some conflicts with your recent work) |
| throw runtime.newTypeError(obj, "Float"); | ||
| } | ||
| return (RubyFloat) TypeConverter.convertToType(obj, runtime.getFloat(), "to_f", true); | ||
| } |
There was a problem hiding this comment.
The old TypeConverter.toFloat appears to only have been used by Pack. Perhaps we can just replace it with the newer impl rather than having two around? I see in MRI it is used in pack.c, but also in random.c. rb_to_float itself is in object.c.
There was a problem hiding this comment.
OK thanks, will look into it ...
| // public IRubyObject fdiv(ThreadContext context, IRubyObject other) { | ||
| // return f_div(context, f_to_f(context, this), other); | ||
| // } | ||
|
|
There was a problem hiding this comment.
I fixed some of these names on the 2.4 branch, so there may be some minor conflicts. No need to keep this commented code in any case.
| final IRubyObject value; | ||
| if (val instanceof java.math.BigDecimal) { | ||
| final RubyClass klass = context.runtime.getClass("BigDecimal"); | ||
| if (klass == null) { // user should require 'bigdecimal' |
There was a problem hiding this comment.
Perhaps we should autoload? I was just thinking yesterday it's odd that BigDecimal is the last numeric type not always loaded. Maybe we should point that out to ruby-core as well?
There was a problem hiding this comment.
guess its not that common to use - like in Java, BigInteger is probably used more than BigDecimal.
... but you're right if all others are core maybe this shouldn't be a lib.
was also thinking of BigDecimal auto-converting Java<->Ruby, however more tricky when the library isn't loaded.
There was a problem hiding this comment.
It seems like many more people would use BigDecimal than Complex to me...I'll ping MRI folks about it.
we're converting to Ruby but all basic num operations now simply work
now same as MRI except maybe toFloat to be moved into RubyObject
kares
force-pushed
the
convert-java-numbers
branch
from
43e4831 to
c60a185
Compare
|
should now be 💚 (based on feedback) ... will pbly wait for the ruby-2.4 merge to resolve potential conflicts |
|
The 2.4 merge will happen tomorrow (Friday 4 Aug). |
|
merged onto master manually: cd08091...2a5b495 |
Java Integration does not fully handle Java's
Numbertype system (primitives as well as java.math classes).mostly Java numeric values are converted back and forth as needed, however there's still a fay to explicitly instanciate Java types (
java.lang.Integer.new(10)etc).improvements presented here try to fix those Java value proxies to seamlessly work with Ruby's conversion rules (e.g.
to_int). there has been requests on these already, added test demonstrate what's now possible.