Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solvespace: Fix path in desktop entry file #27441

Merged
merged 1 commit into from Jul 17, 2017
Merged

solvespace: Fix path in desktop entry file #27441

merged 1 commit into from Jul 17, 2017

Conversation

jfrankenau
Copy link
Member

Motivation for this change

The desktop entry file used Exec=/usr/bin/solvespace before.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @edef

@bjornfor
Copy link
Contributor

If you have time, please notify upstream. The file should use the path to the installed binary, not some hard-coded path.

@joachifm joachifm merged commit aa7d840 into NixOS:master Jul 17, 2017
@jfrankenau jfrankenau deleted the fix-solvespace branch July 20, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @bjornfor @joachifm