Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change pageDone to submitListens #229

Merged
merged 1 commit into from Jul 17, 2017
Merged

Change pageDone to submitListens #229

merged 1 commit into from Jul 17, 2017

Conversation

paramsingh
Copy link
Collaborator

Because pageDone was being called on rate limit exceeds, the
number of pages done was being miscalculated, leading to
import finished messages being shown earlier than expected.
Changing the pageDone call to submitListens fixes this.

@paramsingh
Change pageDone to submitListens
85bd878 
Because pageDone was being called on rate limit exceeds, the
number of pages done was being miscalculated, leading to
import finished messages being shown earlier than expected.
Changing the pageDone call to submitListens fixes this.
mayhem
mayhem approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐔 🇵🇳 🇯🇪 !!! 🌍 !!

@mayhem mayhem merged commit 24d91ec into metabrainz:master Jul 17, 2017
@paramsingh paramsingh deleted the page-done-submit-listens branch July 17, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayhem mayhem mayhem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paramsingh @mayhem