Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcsh: Patch for Git 2.13.2 #27446

Closed
wants to merge 1 commit into from
Closed

vcsh: Patch for Git 2.13.2 #27446

wants to merge 1 commit into from

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jul 17, 2017

Motivation

Fixes #27134.

Testing

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel self-assigned this Jul 17, 2017
@ttuegel ttuegel requested a review from peti July 17, 2017 14:35
peti
peti approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much for figuring out how to fix the test suite!

@peti
Copy link
Member

peti commented Jul 17, 2017

Hmm, I accidentally pushed ac50c4d. 😞 I used that locally for test building and it was not supposed to end up in master. I hope this won't cause any problems?

@ttuegel
Copy link
Member Author

ttuegel commented Jul 17, 2017

No, that should be fine!

@ttuegel ttuegel closed this Jul 17, 2017
@peti peti mentioned this pull request Jul 18, 2017
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees

@ttuegel ttuegel

Labels
0.kind: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttuegel @peti