make __str__ compatible with py2 (six-decorator) #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This the one with decorator. Also see: circuits#232 and circuits#229
prologic
approved these changes
Jul 17, 2017
PEP8 clean up. One blank line was missing.
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 77.2% 77.26% +0.06%
==========================================
Files 80 80
Lines 6716 6717 +1
==========================================
+ Hits 5185 5190 +5
+ Misses 1531 1527 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the one with decorator.
Also see: #232 and #229
A cleaner approve to fix str in Value for Python2. This is the way as six suggests it.
Fixes #229