Check for negative fileno.

We return a negative fileno when a channel is not of a form from which we can extract a real fileno. Not handling that case here led to modes on the resulting IO to be incorrect, causing a stdin- driven DATA to be marked as binmode incorrectly. This fixes that issue and one MRI test (test_DATA_binmode in ruby/test_io.rb).
jruby · Jul 5, 2017 · ddec5e2 · ddec5e2
1 parent c02838c
commit ddec5e2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/core/src/main/java/org/jruby/util/io/FilenoUtil.java b/core/src/main/java/org/jruby/util/io/FilenoUtil.java
@@ -94,7 +94,7 @@ public int getNewFileno() {
     }
 
     public static boolean isFake(int fileno) {
-        return fileno >= FIRST_FAKE_FD;
+        return fileno < 0 || fileno >= FIRST_FAKE_FD;
     }
 
     public static int filenoFrom(Channel channel) {