Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geogebra: make language configurable #26904

Merged
merged 1 commit into from
Jun 27, 2017
Merged

geogebra: make language configurable #26904

merged 1 commit into from
Jun 27, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 27, 2017

Motivation for this change

As a German I'm used to the de_DE GUI of GeoGebra (which contains different function names for several math features). In order to avoid switching between languages I added a parameter to the geogebra derivation which expects an ISO code for the GUI language.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm merged commit c27fc66 into NixOS:master Jun 27, 2017
@Ma27 Ma27 deleted the geogebra/make-language-configurable branch June 27, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants