boost-build: update to version 2016.03 #26903
Merged
+12
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-tkatchev
force-pushed
the
pullrequest4
branch
from
a506c56 to
45f6bb6
Compare
Mic92
reviewed
Jun 27, 2017
| src = fetchurl { | ||
| url = "mirror://sourceforge/boost/${name}.tar.bz2"; | ||
| sha256 = "10sbbkx2752r4i1yshyp47nw29lyi1p34sy6hj7ivvnddiliayca"; | ||
| name = "boost-build-2.0-${version}"; |
There was a problem hiding this comment.
I think 2.0 can be dropped here, no?
There was a problem hiding this comment.
I am a little bit confused about the version schema. This tags seems newer: https://github.com/boostorg/build/releases/tag/boost-1.64.0
Which version is preferred?
There was a problem hiding this comment.
Yes, the "2.0" can be probably dropped, even though it's not really a version number, it's the name of the project after a refactoring effort.
Boost Build releases are not tied to Boost releases, I'm not sure why they have Boost version tags in the repo, but it's probably not a good idea to use them when Boost Build isn't being bundled with Boost itself.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Boost-build as currently in nixpkgs is severely out of date. (Missing support for clang, for example.)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)