Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlang: change default to R19 #26804

Merged
merged 2 commits into from Jun 26, 2017
Merged

erlang: change default to R19 #26804

merged 2 commits into from Jun 26, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 23, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gleber and @mdaiter to be potential reviewers.

@LnL7 LnL7 merged commit 1389f28 into NixOS:master Jun 26, 2017
@LnL7 LnL7 deleted the erlangR19 branch June 26, 2017 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleber gleber gleber approved these changes

@kamilchm kamilchm kamilchm approved these changes

Assignees
No one assigned
Labels
6.topic: erlang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @mention-bot @gleber @kamilchm