Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crashplan: 4.8.2 -> 4.8.3 #26807

Merged
merged 1 commit into from
Jun 24, 2017
Merged

crashplan: 4.8.2 -> 4.8.3 #26807

merged 1 commit into from
Jun 24, 2017

Conversation

forficate
Copy link
Contributor

Refs #26666

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ X] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @sztupi @domenkozar @jerith666

@mention-bot
Copy link

@ajevans85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jerith666, @sztupi and @domenkozar to be potential reviewers.

@jerith666
Copy link
Contributor

This works fine for me. (The Travis CI builds failed with what appears to be an unrelated error, No module named 'dogpile.cache'.)

@Mic92
Copy link
Member

Mic92 commented Jun 24, 2017 •
edited

How do I test this? I get an error on startup:

$ CrashPlanDesktop
/nix/store/hisapihmnadyfap13n9pd6q74q6s4qv3-crashplan-4.8.3-r1/bin/.CrashPlanDesktop-wrapped: line 9: /var/lib/crashplan/bin/run.conf: No such file or directory
Error: Could not find or load main class com.backup42.desktop.CPDesktop

@jerith666
Copy link
Contributor

CrashPlanDesktop is just a front-end for https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/backup/crashplan.nix, so you have to set services.crashplan.enable = true in configuration.nix before it'll do anything useful. (The service creates and populates /var/lib/crashplan.)

@Mic92 Mic92 merged commit 6741b3a into NixOS:master Jun 24, 2017
@Mic92
Copy link
Member

Mic92 commented Jun 24, 2017

Ok. Got tested until I reached the sign-up page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@forficate @mention-bot @jerith666 @Mic92