Skip to content

sway: 0.12.2 -> 0.13.0 #27291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2017
Merged

sway: 0.12.2 -> 0.13.0 #27291

merged 3 commits into from
Jul 12, 2017
+5 −4

Conversation

celldee
Copy link
Contributor

@celldee celldee commented Jul 10, 2017 •
edited
Loading

Motivation for this change
  1. Upgrade to version 0.13.
  2. Allow swaylock lock screen utility to be built by adding build inputs pam and gdk_pixbuf. This was not getting built by the previous package derivation.
  3. Allow swaybg to work correctly by including gdk_pixbuf. Background setting did not work for me using the previous package.
  4. Add version number via cmake flag so that sway -v displays the version number instead of a date and branch.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@celldee, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NeQuissimus, @siddharthist and @domenkozar to be potential reviewers.

@celldee celldee changed the title Sway: 0.12.2 -> 0.13.0 sway: 0.12.2 -> 0.13.0 Jul 12, 2017
@Mic92 Mic92 merged commit 9e72b32 into NixOS:master Jul 12, 2017
@Mic92
Copy link
Member

Mic92 commented Jul 12, 2017

Thanks!

@celldee celldee deleted the sway_0_13_0 branch July 12, 2017 20:35
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@celldee @mention-bot @Mic92 @Janik-Haag