Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Commit ff5423c broke calibre with stacktraces like this one for ebook-edit. The main executable help page does work, but doesn't show this error until you actually try to start the GUI.
It took a number of attempts to identify the cause: basically, the newer html5lib associated with mechanize is found first, rather than the bundled one, and having the old html5lib in the prior location (late in the buildInputs list) causes the same behavior.
Putting the legacy version first in the python package list resolved the issue.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)Edited for commit hash.