Skip to content

jnettop: patch (from Debian) to use 64bit counters for transfer totals. #27283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 10, 2017

Otherwise counters overflow at 4GB.

Motivation for this change

4GB isn't much these days!

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@@ -0,0 +1,104 @@
From: Ari Pollak <aripollak@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it feasible to fetch this from an external source?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I found it on sources.debian.net but I'm not sure how stable that URL is.

Updated the commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately sources.debian.net is not stable because it only covers currently released versions in Debian releases. I'm generally using a tag in Debian's git web interface if the packaging is done in a git repo. For this packages, that isn't the case and we have no other nice source for that patch, so we'll go with sources.debian.net here. Thanks! 👍

@dtzWill dtzWill force-pushed the feature/jnettop-64bit-counters branch from 66ba5cd to 5125a0a Compare July 10, 2017 16:07
@dtzWill
Copy link
Member Author

dtzWill commented Jul 10, 2017

FWIW it appears the source tarball (and all links to the 'jnettop' project website or wiki I can find elsewhere) is no longer available, not sure what the story is there. Thought I'd mention it.

Hooray for tarballs.nixos.org? 😁

@fpletz fpletz merged commit 07f27ed into NixOS:master Jul 10, 2017
@fpletz
Copy link
Member

fpletz commented Jul 10, 2017

Tested. Thanks! That was the biggest annoyance I had with jnettop. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants