pgadmin: make desktop item #27285
Merged
pgadmin: make desktop item #27285
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the .desktop file so that pgAdmin shows up in the menu system of desktop environments (ex. GNOME, XFCE, etc). Closes NixOS#27067
|
@emmanuelrosa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @fpletz and @edolstra to be potential reviewers. |
|
I didn't test it on MacOS since it doesn't use the .desktop file, nor on another Linux distro since they'd expect the .desktop file to be located elsewhere rather than in the Nix store; hence it would be a no-op. I did a smoke test on NixOS unstable, which consisted of checking for a pgAdmin menu entry and then launching the application. |
|
Thanks! |
|
also back ported: b63d2c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the .desktop file so that pgAdmin shows up in the menu
system of desktop environments (ex. GNOME, XFCE, etc).
Closes #27067
Motivation for this change
pgadmin3 not end up on system menu after install, see #27067
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Special request
Please cherry-pick unto release 17.03, since that's where the issue was reported.