Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundix: 2.2.0 -> 2.3.1 #27167

Merged
merged 1 commit into from
Jul 6, 2017
Merged

bundix: 2.2.0 -> 2.3.1 #27167

merged 1 commit into from
Jul 6, 2017
+13 −18

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Jul 6, 2017 •
edited
Loading

Motivation for this change

This should make bundix work for pretty much all environments again.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@manveru, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @edolstra and @robx to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Jul 6, 2017

This fixed the issue of bundix only working without the daemon, and generates output consistent with 2.0.8. 👍

@grahamc grahamc merged commit a07b961 into NixOS:master Jul 6, 2017
@manveru manveru deleted the bundix-2.3.1 branch July 6, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @mention-bot @grahamc