Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languagetool: fix arguments passing #26729

Merged
merged 1 commit into from Jun 24, 2017
Merged

languagetool: fix arguments passing #26729

merged 1 commit into from Jun 24, 2017

Conversation

igsha
Copy link
Contributor

@igsha igsha commented Jun 20, 2017

Motivation for this change

Correctly support arguments in scripts.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested locally:

[22:28] igor@nixos-pc nixpkgs (languagetool) [nix-shell] ✗ (1) % languagetool-commandline --version
LanguageTool version 3.7 (2017-03-27 10:50)
[22:29] igor@nixos-pc nixpkgs (languagetool) [nix-shell] % languagetool-commandline --list
ast-ES Asturian
be-BY Belarusian
br-FR Breton
ca-ES Catalan
ca-ES-valencia Catalan (Valencian)
da-DK Danish
de German
...

@mention-bot
Copy link

@igsha, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @mimadrid and @bjornfor to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Jun 24, 2017

Thanks!

@Mic92 Mic92 merged commit c09d4ae into NixOS:master Jun 24, 2017
@igsha igsha deleted the languagetool branch July 1, 2017 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants