Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv: add openblas support #26733

Merged
merged 1 commit into from Jun 25, 2017
Merged

opencv: add openblas support #26733

merged 1 commit into from Jun 25, 2017

Conversation

juliendehos
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -15,6 +15,7 @@
, enableFfmpeg ? false, ffmpeg
, enableGStreamer ? false, gst_all_1
, enableEigen ? false, eigen
, enableOpenblas ? false, openblas
Copy link
Member

@Mic92 Mic92 Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viric @mdaiter what criterion did you choose to decide which features to enable in opencv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default implementation of blas/lapack is not optimized. Using openblas (or atlas) greatly improves performance.

Ceres-solver may also benefit from this (http://ceres-solver.org/installation.html#dependencies):

On UNIX OSes other than Mac OS X we recommend ATLAS, which includes BLAS and LAPACK routines. It is also possible to use OpenBLAS.

So maybe openblas should be enable in opencv.

@Mic92 Mic92 merged commit 4ef00ca into NixOS:master Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants