-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
xfce.terminal: 0.6.3 -> 0.8.5.1 #26742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Motivated by 0.6.3 being several years old.
@vanschelven, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @Fuuzetsu and @dezgeg to be potential reviewers. |
I can't really weight in on the "by design or not" from the perspective of NixOs; other than the fact that the fact that most packages are stuck on a pre- I did do a bit of research on whether there are any Xfce-given reasons to hold back to the GTK+2 versions, but I can't really find any such indication on their site. As a matter of fact I couldn't find any support schedules on the Xfce site, which leads me to understand their policy as "just push forward and let the distributions deal with the rest" - but I might be wrong. The first version of Xfce that contained GTK+3 components was Xfce 4.12, released on February 28, 2015. Also there's this discussion on moving forward to Xfce 4.14, which talks of a full transition to GTK+3. And then there's "what is everyone else doing"; at least Ubuntu, Fedora & Arch are pushing forward to the new Xfce libraries. Millions of users can't be wrong 😛 |
gtk3 in xfce hasn't been declared stable yet upstream AFAIK. |
Once I have submitted a PR (#16658) to update |
@@ -238,6 +238,8 @@ let | |||
|
|||
vte_290 = callPackage ./core/vte/2.90.nix { }; | |||
|
|||
vte_291 = callPackage ./core/vte/2.91.nix { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are not breaking changes, I would update vte_290
and rename it to vte_29
rather then having a dedicated package.
@volth said
I agree, so I'll close this PR for now. For future reference, I've asked on the xfce dev mailing list what the status of the various projects is. The answer is here: https://mail.xfce.org/pipermail/xfce4-dev/2017-June/031966.html The most important bits are:
|
Well, if we knew 4.14 would be ready before our next stable release (September), I wouldn't be against migrating all Xfce to the gtk3 versions now (in advance), but I don't think they would give similar "guarantees". |
This is my first (possible) contribution to nixpkgs, so be aware of any beginner mistakes.
Particular doubts that I have are:
propagatedBuildInputs
: pcre2 & gnutls. As far as I understand this might be not good practice. The reason I've added them is becausepkg-config
, when run in the build context ofxfce.terminal
, cannot otherwise find the packagevte-2.91
because of a dependency error. Someone moreFeel free to clean up my work or point me in the right direction for doing so. If nothing else, this PR might serve as a point of reference for someone else doing it right.
Motivation for this change
Motivated by 0.6.3 being several years old
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)