Allow JSON::Builder#field to accept non-scalar values.
#4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies writing complex objects as field values:
Instead of `json.field "field" { value.to_json(json) }` you can simply
write ``json.field "field", value`.
Sija
reviewed
Jul 12, 2017
spec/std/json/builder_spec.cr
Outdated
| assert_built(%<{"hash":{"hash":"value"},"object":{"int":12}}>) do | ||
| object do | ||
| field "hash", {"hash" => "value"} | ||
| field "object", TestObject.new |
RX14
approved these changes
Jul 12, 2017
RX14
added
kind:feature
pr:needs-review
status:discussion
topic:stdlib
and removed
status:discussion
labels
|
I've wanted this change in 2 projects now, would be great to get another opinion on this so it could be merged. Here's a snippet from a real project: json.field "avatar" do
json.object do
json.field "id", @avatar_id
json.field "url", "#{config.api_base_url}/v0/avatars/#{@avatar_id || "default"}"
end
endthis would be written more neatly as json.field "avatar", {
id: @avatar_id,
url: "#{config.api_base_url}/v0/avatars/#{@avatar_id || "default"}"
} |
asterite
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies writing complex values in json fields:
Instead of
json.field "field" { value.to_json(json) }you can simplywrite
json.field "field", value.