Skip to content

ncmpcpp: 0.7.7 -> 0.8 #27009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2017
Merged

ncmpcpp: 0.7.7 -> 0.8 #27009

merged 1 commit into from
Jul 1, 2017
+6 −12

Conversation

jfrankenau
Copy link
Member

@jfrankenau jfrankenau commented Jul 1, 2017 •
edited by vbgl
Loading

Motivation for this change

Update.

Note: Curl is now a hard dependency and Unicode is not configurable anymore due to ncursesw being used by default.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @lovek323 @mornfall @koral

Sorry, something went wrong.

@mention-bot
Copy link

@jfrankenau, thanks for your PR! By analyzing the history of the files in this pull request, we identified @codyopel, @k0ral and @lovek323 to be potential reviewers.

@0xABAB
Copy link
Contributor

0xABAB commented Jul 1, 2017

What happened to the unicode support?

@jfrankenau
Copy link
Member Author

@0xABAB, see ncmpcpp/ncmpcpp@5c62072. ncurses with wide character support is now required upstream by default.

@vbgl
Copy link
Contributor

vbgl commented Jul 1, 2017

I’ve just tested it on MacOS: it builds and runs fine. Can you please change the meta.platforms attribute to something less narrow than just linux? Thanks.

@0xABAB
Copy link
Contributor

0xABAB commented Jul 1, 2017

@jfrankenau Thanks for the clarification. I am convinced.

@jfrankenau
Copy link
Member Author

@vbgl, I've set meta.platforms to all.

@vbgl vbgl merged commit 1add351 into NixOS:master Jul 1, 2017
@jfrankenau jfrankenau deleted the update-ncmpcpp branch July 1, 2017 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jfrankenau @mention-bot @0xABAB @vbgl