Skip to content

gst_all_1.gst-plugins-bad: build gtksink plugin #27005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2017
Merged

gst_all_1.gst-plugins-bad: build gtksink plugin #27005

merged 2 commits into from
Jul 17, 2017
+6 −2

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jul 1, 2017

Motivation for this change

Corebird requires gtksink gstreamer plugin to play videos.¹ The plugin, however, is only built when GTK is available.

This patch adds gtk3 as a dependency to gstreamer-plugins-bad package, enabling the build of gtksink.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Tested by running Corebird and playing a video
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@jtojnar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lethalman, @fpletz and @spwhitt to be potential reviewers.

@FRidh
Copy link
Member

FRidh commented Jul 17, 2017

@jtojnar which attribute corresponds to this expression? Its not gst-plugins-bad.

@jtojnar jtojnar force-pushed the fix/corebird-gst branch from 45f0802 to b5d2af4 Compare July 17, 2017 13:10
@jtojnar
Copy link
Member Author

jtojnar commented Jul 17, 2017

@FRidh yes, it is gst-plugins-bad, I updated the commit message.

@jtojnar jtojnar changed the title gstreamer-plugins-bad: build gtksink plugin gst-plugins-bad: build gtksink plugin Jul 17, 2017
@FRidh
Copy link
Member

FRidh commented Jul 17, 2017

So its

$ nix-build -A gst_all_1.gst-plugins-bad

and not

$ nix-build -A gst-plugins-bad

@FRidh
Copy link
Member

FRidh commented Jul 17, 2017

Adding gtk adds 60 MB to the closure. How common is this plugin you need?

@jtojnar jtojnar force-pushed the fix/corebird-gst branch from b5d2af4 to 7ac9c09 Compare July 17, 2017 13:31
@jtojnar jtojnar changed the title gst-plugins-bad: build gtksink plugin gst_all_1.gst-plugins-bad: build gtksink plugin Jul 17, 2017
@jtojnar
Copy link
Member Author

jtojnar commented Jul 17, 2017

You are right, it is for GStreamer 1.

At least Corebird requires the gtk sink, not sure about other packages. Should it be made optional like FAAC support?

@FRidh
Copy link
Member

FRidh commented Jul 17, 2017

Should it be made optional like FAAC support?

I think that would be better, yes. Say we have corebird, then it could override the expression using a version that has this plugin.

@jtojnar jtojnar force-pushed the fix/corebird-gst branch from 7ac9c09 to 368d728 Compare July 17, 2017 14:47
@jtojnar
Copy link
Member Author

jtojnar commented Jul 17, 2017

@FRidh Updated to make GTK optional.

jtojnar added 2 commits July 17, 2017 16:50
@jtojnar
gst_all_1.gst-plugins-bad: allow building gtksink plugin
0edae74 
Corebird requires gtksink gstreamer plugin to play videos. [1] The plugin,
however, is only built when GTK is available.

This patch adds gtk3 as an optional dependency to gst_all_1.gst-plugins-bad
package, allowing the build of gtksink.

[1]: baedert/corebird#431
@jtojnar
corebird: fix video playback

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e564f16 
Corebird requires gst-plugins-bad compiled with GTK support to play
videos.

This commit enables the GTK support.
@jtojnar jtojnar force-pushed the fix/corebird-gst branch from 368d728 to e564f16 Compare July 17, 2017 14:51
@FRidh FRidh merged commit 28b7d01 into NixOS:master Jul 17, 2017
@jtojnar jtojnar deleted the fix/corebird-gst branch July 17, 2017 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xABAB 0xABAB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @mention-bot @FRidh @0xABAB