Skip to content

opencv: Add optional Tesseract support #27011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

Hodapp87
Copy link
Contributor

@Hodapp87 Hodapp87 commented Jul 1, 2017

Motivation for this change

It's a little unclear how to get the OCR support into OpenCV. One other thing this change could do - but which I'm not sure of the right way of going about - is enforcing that if enableTesseract is true, enableContrib must also be true.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@Hodapp87, thanks for your PR! By analyzing the history of the files in this pull request, we identified @basvandijk, @abbradar and @cpages to be potential reviewers.

@basvandijk
Copy link
Member

One way of enabling the contrib modules if enableTesseract is true is replacing all occurrences of enableContrib in the body with buildContrib defined as enableContrib || enableTesseract.

@Hodapp87 Hodapp87 force-pushed the opencv_tesseract branch 4 times, most recently from 4ce6986 to 8687664 Compare July 29, 2017 12:08
@joachifm
Copy link
Contributor

cc @mdaiter

@mdaiter
Copy link
Contributor

mdaiter commented Aug 13, 2017

👍

@joachifm joachifm merged commit 16f6913 into NixOS:master Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants