gen-oath-safe: init at 2017-01-23 #27002
Conversation
| @@ -0,0 +1,44 @@ | |||
| { coreutils, makeWrapper, openssl, libcaca, qrencode, fetchFromGitHub, yubikey-manager, python, stdenv, ... }: | |||
| sha256 = "0018kqmhg0861r5xkbis2a1rx49gyn0dxcyj05wap5ms7zz69m0m"; | ||
| }; | ||
|
|
||
| phases = [ |
There was a problem hiding this comment.
Don't do this. There's no reason for it and it may break things. If you do not need a phase, just write something like buildPhase = ":";.
There was a problem hiding this comment.
Not sure what the difference should be as buildPhase = ":"; may also override behavior in the future which could break the build. Newly introduced phases may also break the build.
if explicitly setting phases is deemed as a bad practice then it might be a good idea to add the recommendation somewhere in the nixpkgs manual.
Nevertheless i will change the package build according to your recommendations.
| description = "Script for generating HOTP/TOTP keys (and QR code)"; | ||
| platforms = platforms.unix; | ||
| license = licenses.mit; | ||
| }; |
There was a problem hiding this comment.
are you going to maintain this package?
There was a problem hiding this comment.
yep, just forgot to add myself to the list of maintainers :)
makefu
force-pushed
the
pkgs/gen-oath-safe/init
branch
from
c9645ae to
f075c0c
Compare
|
thanks for the changes |
|
@FRidh thanks for the code review 👍 |
Motivation for this change
add package from private repo to upstream
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)