Skip to content

ipfs: 0.4.9 -> 0.4.10 #27001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2017
Merged

ipfs: 0.4.9 -> 0.4.10 #27001

merged 1 commit into from
Jul 1, 2017
+4 −4

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jun 30, 2017

Motivation for this change

package update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@zimbatm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kamilchm, @mateon1 and @fpletz to be potential reviewers.

0xABAB
0xABAB approved these changes Jun 30, 2017
View reviewed changes
Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind if these kind of changes by people with commit access would not require review.

@zimbatm
Copy link
Member Author

zimbatm commented Jul 1, 2017

nobody's perfect. for instance I had left a commented-out hash here :)

@zimbatm zimbatm merged commit 3dd29b2 into master Jul 1, 2017
@zimbatm zimbatm deleted the ipfs-0.4.10 branch July 1, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xABAB 0xABAB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @mention-bot @0xABAB