qbittorrent: fix build #27010
Merged
qbittorrent: fix build #27010
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qbittorrent has been broken by 210f688, which adds `qmake` as a build input. `qmake` is overriding the default configure phase (which should be `./configure ...` for qbittorrent) so build goes wrong. Remove `qmake` from build inputs (basically, reverting the said commit).
|
@rasendubi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @codyopel, @simonvandel and @viric to be potential reviewers. |
0xABAB
approved these changes
Jul 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qbittorrent has been broken by 210f688, which adds
qmakeas abuild input.
qmakeis overriding the default configure phase (whichshould be
./configure ...for qbittorrent) so build goes wrong.Remove
qmakefrom build inputs (basically, reverting the saidcommit).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc @ttuegel who has broken the package
cc maintainer @viric