Skip to content

bump rivet, yoda, lhapdf #27366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 18, 2017
Merged

bump rivet, yoda, lhapdf #27366

merged 8 commits into from
Jul 18, 2017
+166 −82

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 13, 2017 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@veprbl veprbl changed the title Version bumps bump rivet, yoda Jul 13, 2017
veprbl added 2 commits July 13, 2017 23:38
@veprbl
lhapdf: 6.1.6 -> 6.2.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6778866
@veprbl
lhapdf: update PDF sets
c7692b1
@veprbl veprbl changed the title bump rivet, yoda bump rivet, yoda, lhapdf Jul 14, 2017
@veprbl
Copy link
Member Author

veprbl commented Jul 15, 2017

Don't merge yet. Need to test lhapdf reverse dependencies.

@veprbl veprbl force-pushed the version_bumps branch 2 times, most recently from e2b137b to c3f9a66 Compare July 17, 2017 07:48
@veprbl
Copy link
Member Author

veprbl commented Jul 17, 2017

nix-shell -p nox --run "nox-review pr 27366" passes on NixOS and Darwin now. Good to merge.

@Mic92
Copy link
Member

Mic92 commented Jul 17, 2017

ok, will look into it.

@Mic92
Copy link
Member

Mic92 commented Jul 17, 2017

Looks like LHAPDF upstream changed its file:

path _/nix/store/vsd414pj6mzwqqi662bpi6zjgwgnkcld-LHAPDF-6.2.0.tar.gz_ has sha256 hash _0gfjps7v93n0rrdndkhp22d93y892bf76pnzdhqbish0cigkkxph_ when _005jfapdj3mmk62p9qgvw7nyg93pqy249p1xy2ws1qx42xj76lih_ was expected

Mic92
Mic92 reviewed Jul 17, 2017
View reviewed changes
pkgs/development/libraries/physics/lhapdf/default.nix Outdated
@@ -6,7 +6,7 @@ stdenv.mkDerivation rec {

src = fetchurl {
url = "http://www.hepforge.org/archive/lhapdf/LHAPDF-${version}.tar.gz";
sha256 = "005jfapdj3mmk62p9qgvw7nyg93pqy249p1xy2ws1qx42xj76lih";
sha256 = "0gfjps7v93n0rrdndkhp22d93y892bf76pnzdhqbish0cigkkxph";
Copy link
Member

@Mic92 Mic92 Jul 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an idea how this can happen? Does the authors reupload their archives or is the archive regenerated? In the latter case fetchzip would be the better choice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92
This happened: https://lhapdf.hepforge.org/hg/lhapdf/
I guess I jumped the gun here. Web pages still list mention 6.1.6 as the latest version: https://lhapdf.hepforge.org/

@Mic92 Mic92 merged commit d945e3c into NixOS:master Jul 18, 2017
@veprbl
Copy link
Member Author

veprbl commented Jul 18, 2017

@Mic92 Thank you!

@veprbl veprbl deleted the version_bumps branch December 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @Mic92