-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Comparing changes
Open a pull request
base repository: NixOS/nixpkgs
base: 706f0c384946
head repository: NixOS/nixpkgs
compare: ea9af6e3bd6a
- 7 commits
- 4 files changed
- 2 contributors
Commits on Jul 12, 2017
-
stdenv-setup: Make the package accumulators associative arrays instea…
…d of strings This is generally cleaner: less eval, less worrying about separators, and probably also faster. I got the idea from that python wrapper script.
3Configuration menu - View commit details
-
Copy full SHA for 8d76eff - Browse repository at this point
Copy the full SHA 8d76effView commit details -
stdenv-setup: Misc improvements as directed by ShellCheck
I took some liberties with the flags-echoing code to make it more concise and correct. Also, a few warnings in findInputs and friends I skipped because I am going to rewrite those anyways. Thanks @grahamc for telling me about this great linter!
Configuration menu - View commit details
-
Copy full SHA for 5d4efb2 - Browse repository at this point
Copy the full SHA 5d4efb2View commit details -
stdenv-setup: Clean up 'substitute()' for style and error handling
It now blows up on null byte in file (rather than silently truncating), and invalid arguments (rather than silently skipping).
Configuration menu - View commit details
-
Copy full SHA for 5d693c8 - Browse repository at this point
Copy the full SHA 5d693c8View commit details
Commits on Jul 13, 2017
-
stdenv-setup: Combine [[ .. ]] && [[ .. ]] into one [[ .. && .. ]]
Also remove useless quotes on same line
Configuration menu - View commit details
-
Copy full SHA for 273a4c1 - Browse repository at this point
Copy the full SHA 273a4c1View commit details -
stdenv-setup: Remove useless quotes
foo=$1 surprisingly doesn't need quotes in Bash. Word splits are only syntactic in string variable (not array var!) assignments.
Configuration menu - View commit details
-
Copy full SHA for 2743078 - Browse repository at this point
Copy the full SHA 2743078View commit details -
stdenv-setup: Pull out and explain 3-part printing of commands
@dezgeg made the good point that the reasons for doing this were not at all intuitive.
2Configuration menu - View commit details
-
Copy full SHA for 30a1420 - Browse repository at this point
Copy the full SHA 30a1420View commit details -
Merge pull request #27336 from obsidiansystems/stdenv-setup-cleanup
Stdenv setup misc cleanups
Configuration menu - View commit details
-
Copy full SHA for ea9af6e - Browse repository at this point
Copy the full SHA ea9af6eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 706f0c384946...ea9af6e3bd6a