Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 706f0c384946
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ea9af6e3bd6a
Choose a head ref
  • 7 commits
  • 4 files changed
  • 2 contributors

Commits on Jul 12, 2017

  1. stdenv-setup: Make the package accumulators associative arrays instea…

    …d of strings
    
    This is generally cleaner: less eval, less worrying about separators,
    and probably also faster. I got the idea from that python wrapper
    script.
    Ericson2314 committed Jul 12, 2017
    3
    Copy the full SHA
    8d76eff View commit details
  2. stdenv-setup: Misc improvements as directed by ShellCheck

    I took some liberties with the flags-echoing code to make it more
    concise and correct. Also, a few warnings in findInputs and friends I
    skipped because I am going to rewrite those anyways.
    
    Thanks @grahamc for telling me about this great linter!
    Ericson2314 committed Jul 12, 2017
    Copy the full SHA
    5d4efb2 View commit details
  3. stdenv-setup: Clean up 'substitute()' for style and error handling

    It now blows up on null byte in file (rather than silently truncating),
    and invalid arguments (rather than silently skipping).
    Ericson2314 committed Jul 12, 2017
    Copy the full SHA
    5d693c8 View commit details

Commits on Jul 13, 2017

  1. stdenv-setup: Combine [[ .. ]] && [[ .. ]] into one [[ .. && .. ]]

    Also remove useless quotes on same line
    Ericson2314 committed Jul 13, 2017
    Copy the full SHA
    273a4c1 View commit details
  2. stdenv-setup: Remove useless quotes

    foo=$1 surprisingly doesn't need quotes in Bash. Word splits are only
    syntactic in string variable (not array var!) assignments.
    Ericson2314 committed Jul 13, 2017
    Copy the full SHA
    2743078 View commit details
  3. stdenv-setup: Pull out and explain 3-part printing of commands

    @dezgeg made the good point that the reasons for doing this were not at
    all intuitive.
    Ericson2314 committed Jul 13, 2017
    2
    Copy the full SHA
    30a1420 View commit details
  4. Merge pull request #27336 from obsidiansystems/stdenv-setup-cleanup

    Stdenv setup misc cleanups
    Ericson2314 authored Jul 13, 2017
    Copy the full SHA
    ea9af6e View commit details
Loading