Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format: raise an error if unclosed paren is found on finish #4698

Merged
merged 1 commit into from Aug 18, 2017
Merged

Format: raise an error if unclosed paren is found on finish #4698

merged 1 commit into from Aug 18, 2017

Conversation

makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Jul 10, 2017 •
edited

Related issue: #4685

One of #4685's confusing points is crystal tool format command is succeeded in spite of invalid result. To prevent false negative, we should raise an error in such a case.

@ysbaddaden ysbaddaden merged commit 372481f into crystal-lang:master Aug 18, 2017
@RX14 RX14 added this to the Next milestone Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:tools:formatter
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makenowjust @asterite @RX14 @ysbaddaden