Skip to content

bochs: 2.6.8 -> 2.6.9 #27278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2017
Merged

bochs: 2.6.8 -> 2.6.9 #27278

merged 1 commit into from
Jul 19, 2017
+54 −97

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jul 10, 2017 •
edited
Loading

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@AndersonTorres AndersonTorres self-assigned this Jul 10, 2017
@mention-bot
Copy link

@AndersonTorres, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin, @aske and @vcunat to be potential reviewers.

FRidh
FRidh reviewed Jul 10, 2017
View reviewed changes
pkgs/applications/virtualization/bochs/default.nix Outdated
, wxSupport ? true, wxGTK ? null
# A plethora of configurable options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do this, its already possible to just override configureFlags with overrideAttrs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I will write a giant configureFlags!

Mic92
Mic92 reviewed Jul 13, 2017
View reviewed changes
pkgs/applications/virtualization/bochs/default.nix Outdated
"--enable-trace-linking"
"--enable-configurable-msrs"
"--enable-show-ips"
"--enable-debugger"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get:

checking for repeated IO and mem copy speedups... yes
checking for gcc / MSVC nmake fast function calls optimization... no
checking for handlers chaining speedups... yes
checking for trace linking speedups support... yes
checking support for configurable MSR registers... yes
checking show IPS... yes
checking for use of .cpp as suffix... no
checking for Bochs internal debugger support... yes
checking for flex... not_found
checking for yacc... not_found
checking whether to generate parser / lexer files... no
checking for disassembler support... yes
checking enable Bochs internal debugger GUI... yes
checking for gdb stub enable... yes
configure: error: --enable-debugger and --enable-gdb-stub are mutually exclusive
builder for ‘/nix/store/155nqasd6hwck25maxdwl6dikc2i1cq9-bochs-2.6.9.drv’ failed with exit code 1
error: build of ‘/nix/store/155nqasd6hwck25maxdwl6dikc2i1cq9-bochs-2.6.9.drv’ failed
/run/current-system/sw/bin/nix-shell: failed to build all dependencies
The invocation of "nix-shell -p bochs" failed
$ git worktree prune
python3 review.py 27278  46.89s user 4.41s system 51% cpu 1:39.71 total

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, frak! The various options are conflicting. I will fix this.

@Mic92
Copy link
Member

Mic92 commented Jul 14, 2017

Is this error a critical one?

$ bochs
========================================================================                                                                                                                      
                       Bochs x86 Emulator 2.6.9                                                                                                                                               
               Built from SVN snapshot on April 9, 2017                                                                                                                                       
                  Compiled on Apr  9 2017 at 06:46:13                                                                                                                                         
========================================================================                                                                                                                      
00000000000i[      ] LTDL_LIBRARY_PATH not set. using compile time default '/nix/store/l6m5mzz4w099wbc35bndpa9qcrxpcxm5-bochs-2.6.9/lib/bochs/plugins'                                        
00000000000i[      ] BXSHARE not set. using compile time default '/nix/store/l6m5mzz4w099wbc35bndpa9qcrxpcxm5-bochs-2.6.9/share/bochs'                                                        
00000000000i[      ] lt_dlhandle is (nil)                                                                                                                                                     
00000000000p[      ] >>PANIC<< dlopen failed for module 'usb_common' (libbx_usb_common.so): file not found                                                                                    
00000000000e[SIM   ] notify called, but no bxevent_callback function is registered                                                                                                            
00000000000e[SIM   ] notify called, but no bxevent_callback function is registered                                                                                                            
========================================================================                                                                                                                      
Bochs is exiting with the following message:                                                                                                                                                  
[      ] dlopen failed for module 'usb_common' (libbx_usb_common.so): file not found                                                                                                          
========================================================================                                                                                                                      
00000000000i[SIM   ] quit_sim called with exit code 1

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jul 15, 2017 •
edited
Loading

@Mic92
Yes, it is; Bochs support for plugins is buggy, I disabled it.
(Indeed, the compile-time messages comply about dlopen and libtool...)

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jul 15, 2017 •
edited
Loading

A question: can I add a "dlxlinux demo" (or any other demo, for that matter) package?

Normally, the precompiled Windows package for Bochs ships a small testing image with a simple Linux distro inside (dlxlinux), to use as demo/test.

I think it would be cool to include a dlxlinux.nix package for it as a proof-of-concept. But maybe it is superfluous and completely optional.

What do you think?

@Mic92
Copy link
Member

Mic92 commented Jul 18, 2017 •
edited
Loading

Mhm. Shouldn't it be trivial to download the image on its own? Also the images seems to be pretty out-dated: https://sourceforge.net/projects/bochs/files/Disk%20Images/

@Mic92 Mic92 merged commit b0614fd into NixOS:master Jul 19, 2017
@AndersonTorres
Copy link
Member Author

Yes, the image is trivial indeed.

@AndersonTorres AndersonTorres deleted the upload-bochs branch February 23, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@FRidh FRidh

Assignees

@AndersonTorres AndersonTorres

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndersonTorres @mention-bot @Mic92 @FRidh