vivaldi: add support for proprietary codecs #26842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to licensing costs, Vivaldi bundles a version of ffmpeg compiled without support for the common H.264 codec. However, it is possible to supply a custom libffmpeg.so with additional codecs. This derivation uses the Chromium source to compile a compatible libffmpeg.so. This approach is recommended by a Vivaldi developer, see https://gist.github.com/ruario/bec42d156d30affef655
|
@lluchs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @otwieracz to be potential reviewers. |
lluchs
force-pushed
the
vivaldi-ffmpeg-codecs
branch
from
3ac31ed
to
cd8cf22
Compare
When trying to open or save a file using the file chooser GUI, Vivaldi would crash with the message GLib-GIO-ERROR **: Settings schema 'org.gtk.Settings.FileChooser' is not installed This commit adds the GTK directory to XDG_DATA_DIRS which fixes the crash.
lluchs
force-pushed
the
vivaldi-ffmpeg-codecs
branch
from
cd8cf22
to
74debc3
Compare
|
I updated the PR. There's now an update script which will check the Vivaldi website for the current version and update both the I also included a (somewhat unrelated) patch for #27299. |
|
Any further comments? Can someone merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As described in #26413, Vivaldi currently doesn't support proprietary codecs such as H.264. This PR adds a
vivaldi-ffmpeg-codecspackage with a libffmpeg.so built from the Chromium source and makes Vivaldi load that library.The build steps are based on the AUR package with the same name.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)