Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geogebra: 5-0-361-0 -> 5-0-369-0 #26836

Merged
merged 1 commit into from
Jun 25, 2017
Merged

geogebra: 5-0-361-0 -> 5-0-369-0 #26836

merged 1 commit into from
Jun 25, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 25, 2017

Motivation for this change

GeoGebra is broken again since the source has been removed from the download server, so an upgrade was necessary again.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obadz and @moyamo to be potential reviewers.


preferLocalBuild = true;

src = fetchurl {
url = "http://download.geogebra.org/installers/5.0/GeoGebra-Linux-Portable-${version}.tar.bz2";
sha256 = "14kidnk8bidklv474zqipv3f77qnfmc697pl407v0rja481c649a";
sha256 = "0b5015z1ff3ksnkmyn2hbfwvhqp1572pdn8llpws32k7w1lb0jnk";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ask them to not delete old releases. Otherwise I would suggest to mirror the source somewhere else (archive.org).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'll notify their support. However I'm unsure about a redistribution (using a service such as archive.org) as meta.licenses lists a geogebra license.

@joachifm joachifm merged commit 90d3a03 into NixOS:master Jun 25, 2017
@Ma27 Ma27 deleted the update/geogebra branch June 25, 2017 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants