Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mopidy-mpris: init at 1.3.1 #26830

Closed
wants to merge 2 commits into from
Closed

mopidy-mpris: init at 1.3.1 #26830

wants to merge 2 commits into from

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Adds new Mopidy extension

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jun 25, 2017 •
edited

This will not with our mpris module (./nixos/modules/services/audio/mopidy.nix), right?

services.mopidy = {
  enable = true;
  extensionPackages = [ pkgs.mopidy-mpris ];
};

$ systemctl status mopidy
...
MPRIS frontend setup failed (org.freedesktop.DBus.Error.NotSupported: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11)
...

This is probably ok, but it would be nice to add a short comment, how mopidy-mpris is supposed to be used.

@rvolosatovs
Copy link
Member Author

rvolosatovs commented Jun 25, 2017 •
edited

I noticed this after I opened the PR, I looked a bit at other packages using DBus/MPRIS, but didn't find a solution yet.
How can this be fixed?
Should DISPLAY be passed on to the environment of the package?

@Mic92
Copy link
Member

Mic92 commented Jun 25, 2017

I don't know how to solve this in a system service. Probably mopidy is supposed to be started in the user session (we have now better support for systemd user services requiring x11/dbus)

@rvolosatovs rvolosatovs deleted the init/mopidy-mpris branch April 16, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: work-in-progress 8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @Mic92 @joachifm