snap: Use the current checkout as source of the snap #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uli-heller
force-pushed
the
fix-snap-current-branch
branch
from
7a54ae9
to
47a74fa
Compare
|
Yes, it's perfectly fine. |
uli-heller
added a commit
to uli-heller/nikola
that referenced
this pull request
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
With this PR, the currently active checkout is used when creating the snap package
instead of the head of the github master.
I'm not sure if this PR is actually a good idea. I just needed a similar approach to build a
snap package of nikola-7.8.9.