vcsh: Refactor - Remove failing vcsh tests. #27452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vcsh tests always fail with the following: Test Summary Report ------------------- t/100-init.t (Wstat: 5120 Tests: 24 Failed: 20) Failed tests: 2, 4-5, 7, 9-24 Non-zero exit status: 20 t/300-add.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=6, Tests=31, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.21 cusr 0.04 csys = 0.29 CPU) Result: FAIL make: *** [Makefile:48: test] Error 1 builder for ‘/nix/store/pp8ybfr0csxwhklvppkyb3wgjlnikwd3-vcsh-1.20170226.drv’ failed with exit code 2 cannot build derivation ‘/nix/store/1ry49szyr5mqrw3cw0fww87cxcahj5xg-system-path.drv’: 1 dependencies couldn't be built killing process 23594 cannot build derivation ‘/nix/store/00jm45b64i2j6m8jnvh0gwyc5zaxl47g-nixos-system-atom-17.03.git.68b6c50b12.drv’: 1 dependencies couldn't be built They don't seem to be properly configured to run on NixOS. This patch allows vcsh to build. The alternative would be to patch the tests in 'vcsh/t' for running on NixOS.
|
@johnramsden, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oxij and @peti to be potential reviewers. |
|
Duh, please don't just disable tests that fail! The proper solution was implemented in #27446 and has been pushed upstream, so this issue should no longer exist. |
|
@peti Perfect, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vcsh tests always fail with the following:
They don't seem to be properly configured to run on NixOS. This patch allows vcsh to build.
The alternative would be to patch the tests in '
vcsh/t' for running on NixOS.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)