Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "mv: argument list too long" for fetchzip in darwin. #27449

Merged
merged 1 commit into from Jul 18, 2017
Merged

Fix "mv: argument list too long" for fetchzip in darwin. #27449

merged 1 commit into from Jul 18, 2017

Conversation

luigy
Copy link
Contributor

@luigy luigy commented Jul 17, 2017

Motivation for this change

Fixes #27448

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@luigy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @cstrahan and @vcunat to be potential reviewers.

@luigy
Copy link
Contributor Author

luigy commented Jul 17, 2017

ping @shlevy

@shlevy
Copy link
Member

shlevy commented Jul 18, 2017

@luigy does this change hashes at all?

@luigy
Copy link
Contributor Author

luigy commented Jul 18, 2017

@shlevy not with this PR that's using a better approach by @Ericson2314

@shlevy shlevy merged commit eb6c45b into NixOS:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetchzip fails on darwin with "mv: Argument list too long"
4 participants
@luigy @mention-bot @shlevy @Janik-Haag