Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simpleitk: init at 1.1.0 (note this only builds the C++ libs, not the Python/Lua/... bindings) #27451

Merged
merged 3 commits into from May 9, 2018
Merged

simpleitk: init at 1.1.0 (note this only builds the C++ libs, not the Python/Lua/... bindings) #27451

merged 3 commits into from May 9, 2018

Conversation

bcdarwin
Copy link
Member

I hope to add the Python and Lua bindings to the relevant package sets separately but depending on this package by checking out the SimpleITK source code but only making the relevant subdirectories.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • [na Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [na] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [na] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Jul 17, 2017
View reviewed changes
pkgs/development/libraries/simpleitk/default.nix Outdated
{ stdenv, fetchurl, cmake, git, swig, lua, itk }:

stdenv.mkDerivation rec {
_name = "simpleitk";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the underscore is non-standard. Instead, use either a let expression or arguments that are commonly used, like pname and version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@bcdarwin
Copy link
Member Author

So I don't think there's any way to build just the bindings separately from the main build, which is annoying since I don't want to build separate versions of this package for all Python, Lua, etc., package sets. Thoughts/relevant example packages in the Nix tree?

@Mic92
Copy link
Member

Mic92 commented Jul 17, 2017 •
edited

Either create multiple outputs or create multiple packages.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build simpleitk

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: simpleitk

Partial log (click to expand)

-- Found Lua: /nix/store/4065mlb9qby6l8s8z5p2c2n93bp9lckj-lua-5.1.5/bin/lua (found version "5.1.5")
-- Could NOT find Tclsh (missing: TCL_TCLSH)
-- Processing json files...
-- Processing json files...done
-- Found SWIG: /nix/store/aa6dflj0ypdsf0xdfa5592srpqswg54n-swig-3.0.12/bin/swig (found suitable version "3.0.12", minimum required is "3")
-- Configuring incomplete, errors occurred!
See also "/build/SimpleITK-1.0.0/build/CMakeFiles/CMakeOutput.log".
See also "/build/SimpleITK-1.0.0/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/pv44dyrmyycsxdlr0xrrs5fj1gg6z2gw-simpleitk-1.0.0.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/pv44dyrmyycsxdlr0xrrs5fj1gg6z2gw-simpleitk-1.0.0.drv' failed

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @GrahamcOfBorg log

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: simpleitk

Partial log (click to expand)

-- Found Lua: /nix/store/vhgy8bnnzynvaqp4y9w2c0x9j1n9fm6c-lua-5.1.5/bin/lua (found version "5.1.5")
-- Could NOT find Tclsh (missing: TCL_TCLSH)
-- Processing json files...
-- Processing json files...done
-- Found SWIG: /nix/store/pwf1b58icrb0hkmdwbsfli8kiginb9rm-swig-3.0.12/bin/swig (found suitable version "3.0.12", minimum required is "3")
-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-simpleitk-1.0.0.drv-0/SimpleITK-1.0.0/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-simpleitk-1.0.0.drv-0/SimpleITK-1.0.0/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/81jfdd9i2manfig8m8sfwr6rbkylyrhg-simpleitk-1.0.0.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/81jfdd9i2manfig8m8sfwr6rbkylyrhg-simpleitk-1.0.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: simpleitk

Partial log (click to expand)

-- Found Lua: /nix/store/czdy5x0w1k66c3r5n8x0idz3i2qpimz6-lua-5.1.5/bin/lua (found version "5.1.5")
-- Could NOT find Tclsh (missing: TCL_TCLSH)
-- Processing json files...
-- Processing json files...done
-- Found SWIG: /nix/store/sfkxsqvhxcwcmz206gi91y0hfs5s7nk0-swig-3.0.12/bin/swig (found suitable version "3.0.12", minimum required is "3")
-- Configuring incomplete, errors occurred!
See also "/build/SimpleITK-1.0.0/build/CMakeFiles/CMakeOutput.log".
See also "/build/SimpleITK-1.0.0/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/4wbdxg90vxcjjj20ly39asr2n3mzr8hx-simpleitk-1.0.0.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/4wbdxg90vxcjjj20ly39asr2n3mzr8hx-simpleitk-1.0.0.drv' failed

@bcdarwin
Copy link
Member Author

I'll try to look into this soon.

@bcdarwin bcdarwin changed the title simpleitk: init at 1.0.0 (note this only builds the C++ libs, not the Python/Lua/... bindings) simpleitk: init at 1.1.0 (note this only builds the C++ libs, not the Python/Lua/... bindings) May 9, 2018
@bcdarwin
Copy link
Member Author

bcdarwin commented May 9, 2018

@GrahamcOfBorg build simpleitk

@bcdarwin
Copy link
Member Author

bcdarwin commented May 9, 2018

@matthewbauer updated version is building locally now.

@matthewbauer matthewbauer merged commit 1e50e17 into NixOS:master May 9, 2018
@bcdarwin bcdarwin deleted the simpleitk branch May 9, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcdarwin @Mic92 @matthewbauer @GrahamcOfBorg @FRidh