Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hid-listen: init at 1.01 #27455

Merged
merged 4 commits into from Jul 18, 2017
Merged

hid-listen: init at 1.01 #27455

merged 4 commits into from Jul 18, 2017

Conversation

TomSmeets
Copy link
Contributor

This tool has to be run as root.

taken from the homepage:

On Ubuntu Linux, the /dev/hidraw device files are not readable by default for normal users. You could create a custom udev rule, or simply run hid_listen with sudo.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@TomSmeets, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @vcunat to be potential reviewers.

bennofs
bennofs reviewed Jul 17, 2017
View reviewed changes
Copy link
Contributor

@bennofs bennofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing I don't quite understand, looks good otherwise! 👍

pkgs/tools/misc/hid-listen/default.nix Outdated

installPhase = ''
mkdir -p $out/bin
mv ./hid_listen $out/bin/$hid_listen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is $hid_listen a variable here? I don't follow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is a mistake.
nice catch!
I will fix this tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bennofs Fixed with 75454c3

TomSmeets and others added 2 commits July 18, 2017 10:28
@TomSmeets
hid-listen: fix typo
75454c3
@bennofs
hid-listen: change platforms to linux only
dbe79a7 
package fails to build on darwin, it doesn't seem clang compatible
and hardcodes certain framework paths
@bennofs
Copy link
Contributor

bennofs commented Jul 18, 2017

I removed darwin from the supported platforms since I couldn't make it work. Will merge the PR after travis build finishes.

@bennofs bennofs merged commit ae28f5c into NixOS:master Jul 18, 2017
@TomSmeets
Copy link
Contributor Author

Ok, thanks for merging.

@TomSmeets TomSmeets deleted the hidlisten branch July 19, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennofs bennofs bennofs left review comments

Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TomSmeets @mention-bot @bennofs @fpletz