Skip to content

xautomation: init at 1.09 #27308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2017
Merged

xautomation: init at 1.09 #27308

merged 1 commit into from
Jul 12, 2017

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Jul 11, 2017

Motivation for this change

This provides xte and related tools for X automation.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an addition to pkgs/top-level/all-packages.nix or similar — how is this meant to be installed? Other than that and the maintainer issue, LGTM!

homepage = https://www.hoopajoo.net/projects/xautomation.html;
description = "Control X from the command line for scripts, and do \"visual scraping\" to find things on the screen";
license = stdenv.lib.licenses.gpl2Plus;
maintainers = with stdenv.lib.maintainers; [viric];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure viric wants to be volunteered for maintaining this package — consider putting yourself there instead :)

@vaibhavsagar
Copy link
Member Author

I forgot about adding this to all-packages.nix, will do that.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lheckemann
Copy link
Member

Thanks for the addition!

@bennofs bennofs merged commit 387256c into NixOS:master Jul 12, 2017
@vaibhavsagar vaibhavsagar deleted the xautomation branch November 29, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants