Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dosbox: 0.74 -> svn #26763

Closed
wants to merge 1 commit into from
Closed

dosbox: 0.74 -> svn #26763

wants to merge 1 commit into from

Conversation

binarin
Copy link
Contributor

@binarin binarin commented Jun 22, 2017

Version 0.74 (released in 2012) of dosbox segfaults, as described at:
https://www.reddit.com/r/linux_gaming/comments/4dxfei/dosbox_segmentation_fault_core_dumped/

dosbox versioning scheme uses only 2 components, so I assume that
using "0.74-4024" is a future-proof method (see the list of existing
https://sourceforge.net/projects/dosbox/files/dosbox/).

Missing dependencies were added:

  • SDL_sound - for mounting .cue files with compressed sound
  • SDL_net - for IPX support
  • libpng - for making screenshots
Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Version 0.74 (released in 2012) of dosbox segfauls, as described at:
https://www.reddit.com/r/linux_gaming/comments/4dxfei/dosbox_segmentation_fault_core_dumped/

dosbox versioning scheme uses only 2 components, so I assume that
using "0.74-4024" is a future-proof method (see the list of existing
https://sourceforge.net/projects/dosbox/files/dosbox/).

Missing dependencies were added:
- SDL_sound - for mounting .cue files with compressed sound
- SDL_net - for IPX support
- libpng - for making screenshots
Copy link
Contributor

@bennofs bennofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the situation with dosbox is unfortunate. The latest release is quite old, but according to #dosbox on freenode should be stable.

So I think we should do the same as for wine: keep the old version, but add the svn version as dosbox-unstable until a new dosbox version is released. To do that, copy default.nix to a new unstable.nix file, restore the original default.nix and include the new package as dosbox-unstable in all-packages.nix.

Additionally, it would be nice if you could list yourself as a maintainer of the new package. For this, you first need to add yourself to lib/maintainers.nix if you haven't done so already and then set meta.maintainers (look at other packages to see how this is done).

name = "dosbox-0.74";
let revision = "4024";
in stdenv.mkDerivation rec {
name = "dosbox-0.74-${revision}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the Nixpkgs manual's Naming Conventions, the name should be dosbox-unstable-2017-06-19.

@binarin binarin closed this Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants