erlangR20: init #26764
Merged
erlangR20: init #26764
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LnL7 @copumpkin (Daniel Pebbles, I know you brought up your concern with having a superfluous amount of Erlang interpreters in the repo for maintenance reasons) |
|
(Mac fails because of aspects out of my control) |
LnL7
reviewed
Jun 22, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -5984,7 +5984,8 @@ with pkgs; | |||
| erlang_basho_R16B02 erlang_basho_R16B02_odbc | |||
| erlangR17 erlangR17_odbc erlangR17_javac erlangR17_odbc_javac | |||
| erlangR18 erlangR18_odbc erlangR18_javac erlangR18_odbc_javac | |||
| erlangR19 erlangR19_odbc erlangR19_javac erlangR19_odbc_javac; | |||
| erlangR19 erlangR19_odbc erlangR19_javac erlangR19_odbc_javac | |||
| erlangR20 erlangR20_odbc erlangR20_javac erlangR20_odbc_javac; | |||
There was a problem hiding this comment.
I think we shouldn't make the list even bigger, just expose R20 here. Other variants are available in beam.interpreters now.
There was a problem hiding this comment.
Do you really want to break the congruency?
LnL7
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add Erlang interpreter version R20 into the main repository.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)