Skip to content

openldap: 2.4.44 -> 2.4.45 ; minikube: 0.19.1 -> 0.20.0 #26766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

openldap: 2.4.44 -> 2.4.45 ; minikube: 0.19.1 -> 0.20.0 #26766

wants to merge 2 commits into from
+6 −6

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Wanted to update minikube.
The openldap build failed with curl errors.
Noticed there is an update to openldap, updated it.
Things work.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

peterhoeg
peterhoeg reviewed Jun 22, 2017
View reviewed changes
pkgs/applications/networking/cluster/minikube/default.nix
@@ -14,23 +14,23 @@ let
# instead, we download localkube ourselves and shove it into the minikube binary. The versions URL that minikube uses is
# currently https://storage.googleapis.com/minikube/k8s_releases.json

localkube-version = "1.6.0";
localkube-version = "1.6.3";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're not using 1.6.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://storage.googleapis.com/minikube/k8sReleases/v${localkube-version}/localkube-linux-amd64 does not exist for 1.6.4

@peterhoeg
Copy link
Member

There is quite a bit of stuff that depends on openldap. Running nox-review would be the safe thing to do.

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Jun 22, 2017 •
edited
Loading

Will do

Edit: Or, I would, if nox-review didn't do this to me:

λ nox-review wip                                                                                                                                           ≠
Traceback (most recent call last):
  File "/nix/store/prfzq2z1nk95jklmzaabdbnnsyqgwk8k-nox-0.0.5/bin/.nox-review-wrapped", line 8, in <module>
    from nox.review import cli
  File "/nix/store/prfzq2z1nk95jklmzaabdbnnsyqgwk8k-nox-0.0.5/lib/python3.6/site-packages/nox/review.py", line 9, in <module>
    from .nixpkgs_repo import get_repo, packages, packages_for_sha
  File "/nix/store/prfzq2z1nk95jklmzaabdbnnsyqgwk8k-nox-0.0.5/lib/python3.6/site-packages/nox/nixpkgs_repo.py", line 5, in <module>
    from .cache import region
  File "/nix/store/prfzq2z1nk95jklmzaabdbnnsyqgwk8k-nox-0.0.5/lib/python3.6/site-packages/nox/cache.py", line 1, in <module>
    from dogpile.cache import make_region
ModuleNotFoundError: No module named 'dogpile.cache'

Edit: Should we send this to staging ?

@NeQuissimus NeQuissimus deleted the minikube_openldap branch June 23, 2017 00:20
@NeQuissimus
Copy link
Member Author

I sent the changes into staging

@peterhoeg
Copy link
Member

ModuleNotFoundError: No module named 'dogpile.cache'

You need this commit: 03a6297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg

@rickynils rickynils

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @peterhoeg