Skip to content

Fix homepage #27220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Fix homepage #27220

merged 1 commit into from
Jul 7, 2017

Conversation

AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Jul 7, 2017

Motivation for this change

Fix broken homepage url discovered by https://repology.org

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@FRidh FRidh merged commit 3abfc16 into NixOS:master Jul 7, 2017
@AMDmi3 AMDmi3 deleted the patch-1 branch July 7, 2017 18:35
@vcunat
Copy link
Member

vcunat commented Jul 7, 2017

They report homepage problems in more than a thousand of our packages...
EDIT: though I'm not sure if I'd count permanent redirects as problems.

@FRidh
Copy link
Member

FRidh commented Jul 7, 2017

Yep, interesting site. Well, maybe, if we ever have too much time on our hands, we might use the API to update all those homepages.

@vcunat
Copy link
Member

vcunat commented Jul 7, 2017

Any idea how https://nixos.org/nixpkgs/packages-unstable.json.gz is updated? Apparently that's what they're using to update but I see the current commit is very old: c5badb1.

@FRidh
Copy link
Member

FRidh commented Jul 7, 2017

@vcunat I asked the same on the IRC channel earlier but then thought of https://github.com/NixOS/nixos-channel-scripts/blob/master/generate-programs-index.cc

@vcunat
Copy link
Member

vcunat commented Jul 7, 2017

I can't see where in particular...

@FRidh
Copy link
Member

FRidh commented Jul 7, 2017

@vcunat
Copy link
Member

vcunat commented Jul 7, 2017

Hmm, that nix-env command seems OK on latest nixpkgs-unstable (0f2db06).

@FRidh
Copy link
Member

FRidh commented Jul 7, 2017

Would be nice if we could make a cron job for this.

@vcunat
Copy link
Member

vcunat commented Jul 7, 2017

I'd think it is automatically updated already.

@FRidh
Copy link
Member

FRidh commented Jul 7, 2017

I checked some of the packages and they were quite old, and repology updates everyday (and had just finished updating). Note also that it uses in fact nixos-unstable.

@FRidh
Copy link
Member

FRidh commented Jul 7, 2017

@vcunat
Copy link
Member

vcunat commented Jul 7, 2017

They update by downloading that file of ours – and that one's outdated for some reason, even though the homepage has updated in the meantime (e.g. the news is weeks newer).

@FRidh
Copy link
Member

FRidh commented Jul 8, 2017

@vcunat I opened #27237 for this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants