Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e08e354e0405
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f2f50aa985d1
Choose a head ref
  • 5 commits
  • 3 files changed
  • 2 contributors

Commits on Jul 7, 2017

  1. stdenv: refactor (no change in semantics) 

    This just moves some expressions around in preparation to further changes.
    @vcunat @Ericson2314
    vcunat authored and Ericson2314 committed Jul 7, 2017
    Copy the full SHA
    7fdf18e View commit details

  2. stdenv: simple refactor to get rid of pos' 

    Suggested by Ericson2314.
    @vcunat @Ericson2314
    vcunat authored and Ericson2314 committed Jul 7, 2017
    Copy the full SHA
    5afcdc8 View commit details

  3. lib.lists.mutuallyExclusive: add function

    @vcunat @Ericson2314
    vcunat authored and Ericson2314 committed Jul 7, 2017
    Copy the full SHA
    dfc004e View commit details

  4. stdenv: separate all meta-checking code (~200 lines) 

    Only cosmetic changes are done otherwise.
Real refactoring is left for later.

There's a small slow-down on my machine:
$ time nix-env -qa -P >/dev/null
gets from ~2.8 to ~3.5 seconds (negligible change in RAM).
That's most likely caused by sharing less computation between different
mkDerivation calls, and I plan to improve that soon.
    @vcunat @Ericson2314
    vcunat authored and Ericson2314 committed Jul 7, 2017
    Copy the full SHA
    e8e5745 View commit details

  5. Merge pull request #27045 from vcunat/meta-refactor-2-rebased 

    stdenv: Refactor meta checks
    @Ericson2314
    Ericson2314 authored Jul 7, 2017
    Copy the full SHA
    f2f50aa View commit details
Loading