gitlab-runner service: add graceful termination #27222
Merged
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachp
force-pushed
the
gitlab-runner-graceful
branch
from
a6ce047 to
dae3112
Compare
0xABAB
reviewed
Jul 8, 2017
| description = '' | ||
| Finish all remaining jobs before stopping, restarting or reconfiguring. | ||
| If not set gitlab-runner will stop immediatly without waiting for jobs to finish, | ||
| which will lead to faild builds. |
There was a problem hiding this comment.
Also misses a comma after set.
0xABAB
reviewed
Jul 8, 2017
| default = "infinity"; | ||
| type = types.string; | ||
| example = "5min 20s"; | ||
| description = ''Time to wait till a graceful shutdown is turned into a forceful one''; |
bachp
force-pushed
the
gitlab-runner-graceful
branch
from
dae3112 to
ced6c0f
Compare
Mic92
reviewed
Jul 9, 2017
| @@ -15,6 +15,23 @@ in | |||
| description = "Verbatim config.toml to use"; | |||
| }; | |||
|
|
|||
| graceful = mkOption { | |||
There was a problem hiding this comment.
Maybe rename gracefulRestart? This sounds more informative to me.
There was a problem hiding this comment.
I tought about gracefulTermination as well as this most accurately describes what it actually does.
The current behavior was for gitlab-runner is to immediately terminate when there was a restart required. This can lead to aborted builds and is annoying to users. By enabling graceful mode gitlab-runner will wait for all builds to finish before terminating. The disadvantage is that a nixos-rebuild switch needs to wait till all jobs are done. Because of that it is not enabled by default.
bachp
force-pushed
the
gitlab-runner-graceful
branch
from
ced6c0f to
3d9ea26
Compare
bachp
changed the title
fpletz
approved these changes
Jul 10, 2017
zimbatm
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The current behavior was for gitlab-runner is to immediately terminate when there
was a restart required. This can lead to aborted builds and is annoying to users.
By enabling graceful mode gitlab-runner will wait for all builds to finish before
terminating. The disadvantage is that a nixos-rebuild switch needs to wait till
all jobs are done. Because of that it is not enabled by default.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)