go_1_6: Fix darwin (sierra) compile, backport systime syscall fix #27230
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patches go1.6 minimally with a change that was backported to upstream go1.4.
|
Awesome, I hated this bug enough to file an issue with Go asking them to stop writing their own syscall wrappers 😄 I don't use Go 1.6 anymore, but this looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches go1.6 minimally with a change that was backported
to upstream go1.4.
Motivation for this change
Trying to reproduce #18223, the build failed for me quite a bit worse, with stack traces such as in this golang issue: golang/go#16627
It turns out that go1.6 is broken on macOS sierra. Not sure to what extent it makes sense to keep go1.6 working, but this adds a patch that fixes the build on my system.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)